Pin Anchor version to 0.32.1 instead of using latest#65
Open
S0nee wants to merge 1 commit intomagicblock-labs:mainfrom
Open
Pin Anchor version to 0.32.1 instead of using latest#65S0nee wants to merge 1 commit intomagicblock-labs:mainfrom
S0nee wants to merge 1 commit intomagicblock-labs:mainfrom
Conversation
Replaced `avm install latest` and `avm use latest` with the explicitly specified version `0.32.1`, which is mentioned at the beginning of the documentation: Updated the installation commands to match the declared Anchor version to avoid potential inconsistencies. ### Notes: I’m not 100% sure this is the intended approach, so I decided to create this as a separate PR instead of combining it with the previous changes in the same file (see related PR: #XXX).
|
@S0nee is attempting to deploy a commit to the Jonas' projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
WalkthroughThe pull request updates Anchor Framework installation instructions in the README file by replacing dynamic version selection through Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
anchor-rock-paper-scissor/README.md (1)
39-42:⚠️ Potential issue | 🟡 MinorPre-existing Solana CLI version mismatch in the install command.
The install URL on Line 41 hard-codes
v1.18.0, but the versioning table (Line 19) and prerequisites (Line 28) both declare Solana2.3.13. A developer following the guide will install the wrong CLI version.📝 Proposed fix
-sh -c "$(curl -sSfL https://release.solana.com/v1.18.0/install)" +sh -c "$(curl -sSfL https://release.solana.com/v2.3.13/install)"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@anchor-rock-paper-scissor/README.md` around lines 39 - 42, The README install command hard-codes "v1.18.0" which conflicts with the documented Solana version "2.3.13"; update the install URL in the install step (the sh -c "$(curl -sSfL https://release.solana.com/v1.18.0/install)" line) to use "v2.3.13" (or reference the same version variable used in the prerequisites/version table) so the CLI version in the install step matches the declared Solana version.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@anchor-rock-paper-scissor/README.md`:
- Around line 39-42: The README install command hard-codes "v1.18.0" which
conflicts with the documented Solana version "2.3.13"; update the install URL in
the install step (the sh -c "$(curl -sSfL
https://release.solana.com/v1.18.0/install)" line) to use "v2.3.13" (or
reference the same version variable used in the prerequisites/version table) so
the CLI version in the install step matches the declared Solana version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
avm install latestandavm use latestwith the explicitly specified version0.32.1, which is mentioned at the beginning of the documentation:Updated the installation commands to match the declared Anchor version to avoid potential inconsistencies.
Notes:
I’m not 100% sure this is the intended approach, so I decided to create this as a separate PR instead of combining it with the previous changes in the same file (see related PR: #64).
Summary by CodeRabbit